tracing: add missing Future impl for WithDispatch
#1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbarsky
approved these changes
Sep 30, 2021
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
force-pushed
the
eliza/fix-missing-future-impl
branch
from
624ecd7
to
b37ac41
Compare
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Oct 1, 2021
The version of `WithSubscriber` in `tracing::instrument` (rather than in `tracing-futures`) is currently...useless, since there is no `Future` impl for the `WithDispatch` type. This means that calling `with_collector` on a `Future` returns a value that _isn't_ a `Future`. Additionally, the `WithSubscriber` trait isn't actually implemented for anything (although this was fixed on v0.1.x). This branch adds the missing implementations. I also improved the docs a bit. Note that the `Future` impl requires the "std" feature flag, but the `WithSubscriber` trait and `WithDispatch` type do not. This is because requiring the feature flag for these definitions would *technically* be a breaking change, since they were previously published without the feature flag and could e.g. be imported...even though they were totally useless. Sigh. Signed-off-by: Eliza Weisman <eliza@buoyant.io> ; Conflicts: ; tracing/src/instrument.rs
hawkw
added a commit
that referenced
this pull request
Oct 1, 2021
The version of `WithSubscriber` in `tracing::instrument` (rather than in `tracing-futures`) is currently...useless, since there is no `Future` impl for the `WithDispatch` type. This means that calling `with_collector` on a `Future` returns a value that _isn't_ a `Future`. Additionally, the `WithSubscriber` trait isn't actually implemented for anything (although this was fixed on v0.1.x). This branch adds the missing implementations. I also improved the docs a bit. Note that the `Future` impl requires the "std" feature flag, but the `WithSubscriber` trait and `WithDispatch` type do not. This is because requiring the feature flag for these definitions would *technically* be a breaking change, since they were previously published without the feature flag and could e.g. be imported...even though they were totally useless. Sigh. Signed-off-by: Eliza Weisman <eliza@buoyant.io> ; Conflicts: ; tracing/src/instrument.rs
hawkw
added a commit
that referenced
this pull request
Oct 5, 2021
# 0.1.29 (October 5th, 2021 This release adds support for recording `Option<T> where T: Value` as typed `tracing` field values. It also includes significant performance improvements for functions annotated with the `#[instrument]` attribute when the generated span is disabled. ### Changed - `tracing-core`: updated to v0.1.21 - `tracing-attributes`: updated to v0.1.19 ### Added - **field**: `Value` impl for `Option<T> where T: Value` ([#1585]) - **attributes**: - improved performance when skipping `#[instrument]`-generated spans below the max level ([#1600], [#1605], [#1614], [#1616], [#1617]) ### Fixed - **instrument**: added missing `Future` implementation for `WithSubscriber`, making the `WithDispatch` extension trait actually useable ([#1602]) - Documentation fixes and improvements ([#1595], [#1601], [#1597]) Thanks to @BrianBurgers, @mattiast, @DCjanus, @oli-obk, and @matklad for contributing to this release! [#1585]: #1585 [#1595]: #1596 [#1597]: #1597 [#1600]: #1600 [#1601]: #1601 [#1602]: #1602 [#1614]: #1614 [#1616]: #1616 [#1617]: #1617
hawkw
added a commit
that referenced
this pull request
Oct 5, 2021
# 0.1.29 (October 5th, 2021 This release adds support for recording `Option<T> where T: Value` as typed `tracing` field values. It also includes significant performance improvements for functions annotated with the `#[instrument]` attribute when the generated span is disabled. ### Changed - `tracing-core`: updated to v0.1.21 - `tracing-attributes`: updated to v0.1.19 ### Added - **field**: `Value` impl for `Option<T> where T: Value` ([#1585]) - **attributes**: - improved performance when skipping `#[instrument]`-generated spans below the max level ([#1600], [#1605], [#1614], [#1616], [#1617]) ### Fixed - **instrument**: added missing `Future` implementation for `WithSubscriber`, making the `WithDispatch` extension trait actually useable ([#1602]) - Documentation fixes and improvements ([#1595], [#1601], [#1597]) Thanks to @BrianBurgers, @mattiast, @DCjanus, @oli-obk, and @matklad for contributing to this release! [#1585]: #1585 [#1595]: #1596 [#1597]: #1597 [#1600]: #1600 [#1601]: #1601 [#1602]: #1602 [#1614]: #1614 [#1616]: #1616 [#1617]: #1617
hawkw
added a commit
that referenced
this pull request
Oct 6, 2021
# 0.1.29 (October 5th, 2021 This release adds support for recording `Option<T> where T: Value` as typed `tracing` field values. It also includes significant performance improvements for functions annotated with the `#[instrument]` attribute when the generated span is disabled. ### Changed - `tracing-core`: updated to v0.1.21 - `tracing-attributes`: updated to v0.1.19 ### Added - **field**: `Value` impl for `Option<T> where T: Value` ([#1585]) - **attributes**: - improved performance when skipping `#[instrument]`-generated spans below the max level ([#1600], [#1605], [#1614], [#1616], [#1617]) ### Fixed - **instrument**: added missing `Future` implementation for `WithSubscriber`, making the `WithDispatch` extension trait actually useable ([#1602]) - Documentation fixes and improvements ([#1595], [#1601], [#1597]) Thanks to @BrianBurgers, @mattiast, @DCjanus, @oli-obk, and @matklad for contributing to this release! [#1585]: #1585 [#1595]: #1596 [#1597]: #1597 [#1600]: #1600 [#1601]: #1601 [#1602]: #1602 [#1605]: #1605 [#1614]: #1614 [#1616]: #1616 [#1617]: #1617
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
The version of `WithSubscriber` in `tracing::instrument` (rather than in `tracing-futures`) is currently...useless, since there is no `Future` impl for the `WithDispatch` type. This means that calling `with_collector` on a `Future` returns a value that _isn't_ a `Future`. Additionally, the `WithSubscriber` trait isn't actually implemented for anything (although this was fixed on v0.1.x). This branch adds the missing implementations. I also improved the docs a bit. Note that the `Future` impl requires the "std" feature flag, but the `WithSubscriber` trait and `WithDispatch` type do not. This is because requiring the feature flag for these definitions would *technically* be a breaking change, since they were previously published without the feature flag and could e.g. be imported...even though they were totally useless. Sigh. Signed-off-by: Eliza Weisman <eliza@buoyant.io> ; Conflicts: ; tracing/src/instrument.rs
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.1.29 (October 5th, 2021 This release adds support for recording `Option<T> where T: Value` as typed `tracing` field values. It also includes significant performance improvements for functions annotated with the `#[instrument]` attribute when the generated span is disabled. ### Changed - `tracing-core`: updated to v0.1.21 - `tracing-attributes`: updated to v0.1.19 ### Added - **field**: `Value` impl for `Option<T> where T: Value` ([tokio-rs#1585]) - **attributes**: - improved performance when skipping `#[instrument]`-generated spans below the max level ([tokio-rs#1600], [tokio-rs#1605], [tokio-rs#1614], [tokio-rs#1616], [tokio-rs#1617]) ### Fixed - **instrument**: added missing `Future` implementation for `WithSubscriber`, making the `WithDispatch` extension trait actually useable ([tokio-rs#1602]) - Documentation fixes and improvements ([tokio-rs#1595], [tokio-rs#1601], [tokio-rs#1597]) Thanks to @BrianBurgers, @mattiast, @DCjanus, @oli-obk, and @matklad for contributing to this release! [tokio-rs#1585]: tokio-rs#1585 [tokio-rs#1595]: tokio-rs#1596 [tokio-rs#1597]: tokio-rs#1597 [tokio-rs#1600]: tokio-rs#1600 [tokio-rs#1601]: tokio-rs#1601 [tokio-rs#1602]: tokio-rs#1602 [tokio-rs#1605]: tokio-rs#1605 [tokio-rs#1614]: tokio-rs#1614 [tokio-rs#1616]: tokio-rs#1616 [tokio-rs#1617]: tokio-rs#1617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The version of
WithCollectorintracing::instrument(rather than intracing-futures) is currently...useless, since there is noFutureimpl for the
WithDispatchtype. This means that callingwith_collectoron aFuturereturns a value that isn't aFuture.Additionally, the
WithCollectortrait isn't actually implemented foranything (although this was fixed on v0.1.x).
Solution
This branch adds the missing implementations. I also improved the docs a
bit.