Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying XCTest #641

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Applying XCTest #641

wants to merge 6 commits into from

Conversation

jebeomgyeong
Copy link

Development Environment

  • Xcode 11.3.1 (11C504)
  • macOS Catalina 10.15.4 Beta (19E234g)

Deployment Target

  • macOS 10.7

Change Log

  • GHUnit is removed because it's a deprecated project.
  • XCTest is applied.
  • Code coverage is enabled.
  • GBLogX... is replaced with GBLog.... GBLogX... is supposed to print the file name that has the log. But DDLog that GBLog... and GBLogX... are using has an issue to print character array. In order to set the file name to nil, some macros are copied into GBLog.h from DDLog. This is a workaround.

Todo

@tomaz
Copy link
Owner

tomaz commented Mar 4, 2020

Thanks! Would it be a lot of work to make GBLogX.... macros working? They're used for integrating logs with Xcode, so they may be important for some developers...

@jebeomgyeong
Copy link
Author

@tomaz I'm going to look into the GBLogX things. It might be solved easily if we can use the latest version of CocoaLumberjack.

Can you tell me how the log integration works on Xcode? Is there any special format for the log? I'm not familiar with it.

@tomaz
Copy link
Owner

tomaz commented Mar 4, 2020

Exactly, that's all there is to it, don't remember exact format either, but I think full file path and line number is needed

@jebeomgyeong
Copy link
Author

@tomaz Okay. I'm going to update this PR after understanding the log integration. If it takes longer than a week, I'll leave the comment about the progress.

@tomaz
Copy link
Owner

tomaz commented Mar 4, 2020

Thanks!

@MohitPatni0731
Copy link

Looks perfect now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants