Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to set a fallback url #17

Merged
merged 2 commits into from
May 15, 2019

Conversation

svenjungnickel
Copy link

Short description of what this resolves:

This commit allows to set a fallback url in case the provided url is not accessible.

Changes proposed in this pull request:

That is triggered by setting the key "fallback-url" for the element like this:

"tool" : {
    "url" : "https://not-accessible-url/tool.phar",
    "fallback-url" : "https://fallback-url/tool.phar"
}

In case the provided url is not accessible, the code will check for the fallback-url key and if set, the fallback url will be checked for accessibility and used to download the asset. Otherwise it displays the error message At least one given URL are not accessible!.

Fixes: #

@tommy-muehle tommy-muehle merged commit dbc5778 into tommy-muehle:master May 15, 2019
@tommy-muehle
Copy link
Owner

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants