Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checksum of not accessible url using fall back url #18

Merged
merged 2 commits into from
Jun 24, 2019

Conversation

svenjungnickel
Copy link

Short description of what this resolves:

This commit addresses a fix for the FileAlreadyExistDecision.php for a not accessible url.

Changes proposed in this pull request:

In case the provided url is not accessible and the downloaded file already exists, a ErrorException sha1_file(http://notaccessible.url/version/tool.phar): failed to open stream: Operation timed out was thrown. This commit fixes this issue by adding an extra check for the accessibility of the url. If the url is not accessible, the fallback url is used for the checksum.

Version: 1.4.0

Fixes: #

@svenjungnickel
Copy link
Author

Hey @tommy-muehle, any chance to get this PR merged soon? It fixes an issue in the latest version 1.4.0 with the new fallback url feature. You basically just have to merge and tag a bugfix version :)

@tommy-muehle
Copy link
Owner

Thanks for the fix. And sorry for the late response!

@tommy-muehle tommy-muehle merged commit 0f2d81f into tommy-muehle:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants