Update mypy and various typing improvements #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt to newer upstream types for AbstractEventLoop
Revealed an issue in websocket.py in which bytes were used when it should have been str. This avoided being a bug because something down the line was converting it to str but it was still a logical type error. The change to httputil.py was taken from tornadoweb#3329 (thanks mslynch). Closes tornadoweb#3329 Fixes tornadoweb#3328
Its default type is `Tuple[str, str, str, str, str, str, str]`, which can only be overridden by a tuple of the exact same length. This change originated in tornadoweb#3354 (thanks alexmv and andersk). Closes tornadoweb#3354
In practice, UIModule.render often returns the result of self.render_string, which returns bytes. In fact, we have an example of that in this file which had a type ignore comment. UIModule.render may now return either str or bytes and downstream code is responsible for handling this. (Note that the new call to _unicode appears to be redundant since the Template module's bytes return was already working correctly, but this conversion is necessary to satisfy the type checker.) Fixes tornadoweb#3050
This method has always accepted both asyncio and concurrent futures, but the type hint incorrectly indicated that it only accepted asyncio futures. Fixes tornadoweb#3314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up most of the open typing-related issues and PRs; see individual commits for details.
Fixes #3328
Fixes #3354
Fixes #3050
Fixes #3314