Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use include-hidden-files: true to upload coverage artifacts #298

Merged

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Sep 3, 2024

Version v4.4.0 of actions/upload-artifact broke uploading (silently) and combining coverage files.

Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow great find, thank you! Would you mind doing this for Hatch? 😄

@ofek ofek merged commit 9e539d7 into tox-dev:main Sep 3, 2024
32 checks passed
@edgarrmondragon
Copy link
Contributor Author

Wow great find, thank you! Would you mind doing this for Hatch? 😄

Sure!

@edgarrmondragon edgarrmondragon deleted the upload-artifact-include-hidden-files branch September 3, 2024 18:08
ldetmer pushed a commit to googleapis/sdk-platform-java that referenced this pull request Sep 9, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [platformdirs](https://redirect.github.com/platformdirs/platformdirs)
| `==4.2.2` -> `==4.3.2` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/platformdirs/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/platformdirs/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/platformdirs/4.2.2/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/platformdirs/4.2.2/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>platformdirs/platformdirs (platformdirs)</summary>

###
[`v4.3.2`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.2)

[Compare
Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.3.1...4.3.2)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Use uv as installer by
[@&#8203;gaborbernat](https://redirect.github.com/gaborbernat) in
[tox-dev/platformdirs#300
- Fix multi-path returned from `_path` methods on MacOS by
[@&#8203;matthewhughes934](https://redirect.github.com/matthewhughes934)
in
[tox-dev/platformdirs#299

#### New Contributors

-
[@&#8203;matthewhughes934](https://redirect.github.com/matthewhughes934)
made their first contribution in
[tox-dev/platformdirs#299

**Full Changelog**:
tox-dev/platformdirs@4.3.1...4.3.2

###
[`v4.3.1`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.1)

[Compare
Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.3.0...4.3.1)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

**Full Changelog**:
tox-dev/platformdirs@4.3.0...4.3.1

###
[`v4.3.0`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.0)

[Compare
Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.2.2...4.3.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Speed up Hatch installation by
[@&#8203;ofek](https://redirect.github.com/ofek) in
[tox-dev/platformdirs#282
- Test with Python 3.13 by
[@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
in
[tox-dev/platformdirs#289
- Test with latest PyPy by
[@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
in
[tox-dev/platformdirs#290
- Use `include-hidden-files: true` to upload coverage artifacts by
[@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
in
[tox-dev/platformdirs#298
- Ensure PlatformDirs is valid superclass type for mypy AND not an
abstract class for other checkers by
[@&#8203;Avasam](https://redirect.github.com/Avasam) in
[tox-dev/platformdirs#295

#### New Contributors

- [@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
made their first contribution in
[tox-dev/platformdirs#289
- [@&#8203;Avasam](https://redirect.github.com/Avasam) made their first
contribution in
[tox-dev/platformdirs#295

**Full Changelog**:
tox-dev/platformdirs@4.2.2...4.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
ldetmer pushed a commit to googleapis/sdk-platform-java that referenced this pull request Sep 17, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [platformdirs](https://redirect.github.com/platformdirs/platformdirs)
| `==4.2.2` -> `==4.3.2` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/platformdirs/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/platformdirs/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/platformdirs/4.2.2/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/platformdirs/4.2.2/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>platformdirs/platformdirs (platformdirs)</summary>

###
[`v4.3.2`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.2)

[Compare
Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.3.1...4.3.2)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Use uv as installer by
[@&#8203;gaborbernat](https://redirect.github.com/gaborbernat) in
[tox-dev/platformdirs#300
- Fix multi-path returned from `_path` methods on MacOS by
[@&#8203;matthewhughes934](https://redirect.github.com/matthewhughes934)
in
[tox-dev/platformdirs#299

#### New Contributors

-
[@&#8203;matthewhughes934](https://redirect.github.com/matthewhughes934)
made their first contribution in
[tox-dev/platformdirs#299

**Full Changelog**:
tox-dev/platformdirs@4.3.1...4.3.2

###
[`v4.3.1`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.1)

[Compare
Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.3.0...4.3.1)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

**Full Changelog**:
tox-dev/platformdirs@4.3.0...4.3.1

###
[`v4.3.0`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.0)

[Compare
Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.2.2...4.3.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Speed up Hatch installation by
[@&#8203;ofek](https://redirect.github.com/ofek) in
[tox-dev/platformdirs#282
- Test with Python 3.13 by
[@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
in
[tox-dev/platformdirs#289
- Test with latest PyPy by
[@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
in
[tox-dev/platformdirs#290
- Use `include-hidden-files: true` to upload coverage artifacts by
[@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
in
[tox-dev/platformdirs#298
- Ensure PlatformDirs is valid superclass type for mypy AND not an
abstract class for other checkers by
[@&#8203;Avasam](https://redirect.github.com/Avasam) in
[tox-dev/platformdirs#295

#### New Contributors

- [@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
made their first contribution in
[tox-dev/platformdirs#289
- [@&#8203;Avasam](https://redirect.github.com/Avasam) made their first
contribution in
[tox-dev/platformdirs#295

**Full Changelog**:
tox-dev/platformdirs@4.2.2...4.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants