Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes during review of PR 35492 #52

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Changes during review of PR 35492 #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46d58c5
Changes during review of PR 35492
mmasciov Oct 4, 2021
ab20cf5
Increase maxEta_regSort (used in mkFit region sorting), for safety
mmasciov Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions RecoTracker/MkFit/plugins/MkFitIterationConfigESProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,25 @@ namespace {
IterationSeedPartition &part) {
// Seeds are placed into eta regions and sorted on region + eta.

const int size = in_seeds.size();
const size_t size = in_seeds.size();

for (int i = 0; i < size; ++i) {
for (size_t i = 0; i < size; ++i) {
const Track &S = in_seeds[i];

const bool z_dir_pos = S.pz() > 0;

HitOnTrack hot = S.getLastHitOnTrack();
// MIMI ACHTUNG -- here we assume seed hits have already been remapped.
// This was true at that time :)
float eta = eoh[hot.layer].GetHit(hot.index).eta();
const float eta = eoh[hot.layer].GetHit(hot.index).eta();
// float eta = S.momEta();

// Region to be defined by propagation / intersection tests
TrackerInfo::EtaRegion reg;

// Max eta used for region sorting
constexpr float maxEta_regSort = 7.0;

// Hardcoded for cms ... needs some lists of layers (hit/miss) for brl / ecp tests.
// MM: Check lambda functions/std::function
const LayerInfo &outer_brl = trk_info.outer_barrel_layer();
Expand All @@ -56,7 +59,7 @@ namespace {
// There are a lot of tracks that go through that crack.

// XXXX trying a fix for low pT tracks that are in barrel after half circle
float maxR = S.maxReachRadius();
const float maxR = S.maxReachRadius();
float z_at_maxr;

bool can_reach_outer_brl = S.canReachRadius(outer_brl.m_rout);
Expand Down Expand Up @@ -97,7 +100,10 @@ namespace {
}

part.m_region[i] = reg;
part.m_sort_score[i] = 5.0f * (reg - 2) + eta;

// TrackerInfo::EtaRegion is enum from 0 to 5 (Reg_Endcap_Neg,Reg_Transition_Neg,Reg_Barrel,Reg_Transition_Pos,Reg_Endcap_Pos)
// Symmetrization around TrackerInfo::Reg_Barrel for sorting is required
part.m_sort_score[i] = maxEta_regSort * (reg - TrackerInfo::Reg_Barrel) + eta;
}
}
} // namespace
Expand Down