fix: 🐛 add divisor: '1' to GOMAXPROCS and GOMEMLIMIT

traefik · Jun 6, 2024 · 9ccbee2 · 9ccbee2
1 parent db4f43f
commit 9ccbee2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/traefik/templates/_podtemplate.tpl b/traefik/templates/_podtemplate.tpl
@@ -704,12 +704,14 @@
             valueFrom:
               resourceFieldRef:
                 resource: limits.cpu
+                divisor: '1'
           {{- end }}
           {{- if ($.Values.resources.limits).memory }}
           - name: GOMEMLIMIT
             valueFrom:
               resourceFieldRef:
                 resource: limits.memory
+                divisor: '1'
           {{- end }}
           {{- with .Values.hub.token }}
           - name: HUB_TOKEN

diff --git a/traefik/tests/pod-config_test.yaml b/traefik/tests/pod-config_test.yaml
@@ -17,6 +17,9 @@ tests:
       - equal:
           path: spec.template.spec.containers[0].env[0].valueFrom.resourceFieldRef.resource
           value: limits.cpu
+      - equal:
+          path: spec.template.spec.containers[0].env[0].valueFrom.resourceFieldRef.divisor
+          value: "1"
   - it: should have set GOMEMLIMIT with cpu limit
     set:
       resources:
@@ -29,6 +32,9 @@ tests:
       - equal:
           path: spec.template.spec.containers[0].env[0].valueFrom.resourceFieldRef.resource
           value: limits.memory
+      - equal:
+          path: spec.template.spec.containers[0].env[0].valueFrom.resourceFieldRef.divisor
+          value: "1"
   - it: should have not set GOMAXPROCS without cpu limit
     asserts:
       - notEqual: