Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deletecollection right on secrets #1077

Merged
merged 2 commits into from
May 28, 2024

Conversation

jspdown
Copy link
Contributor

@jspdown jspdown commented May 24, 2024

What does this PR do?

This PR adds the deletecollection right on Secrets.

Motivation

The goal is to allow Traefik Hub controller to delete Secrets more efficiently when cleaning up outdated resources.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

@mloiseleur
Copy link
Contributor

Thanks for this PR, @jspdown !
This chart allows to choose between namespace rbac or cluster-wide rbac. It seems this PR covers only cluster role.
Would you please update role.yaml accordingly ?

@jspdown
Copy link
Contributor Author

jspdown commented May 27, 2024

@mloiseleur Thanks for your review. I've updated the PR accordingly.

Please note that I made some cleanup as well:

  • Removing duplicated resource rights (services and endpoints)
  • Removed resources that are no longer supported (edgeingresses, deployment, statefulsets, and daemonsets)
  • Removed write access on ingresses

@traefiker traefiker force-pushed the feat/secret-deletecollection-rbac branch from b8b6c28 to 788bebf Compare May 28, 2024 13:22
@traefiker traefiker merged commit fb69807 into traefik:master May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants