Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 add divisor: '1' to GOMAXPROCS and GOMEMLIMIT #1085

Merged
merged 3 commits into from
Jun 6, 2024
Merged

fix: 🐛 add divisor: '1' to GOMAXPROCS and GOMEMLIMIT #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b9e9ff
fix: add divisor: '1' to GOMAXPROCS and GOMEMLIMIT
hawkesn Jun 5, 2024
3d6bb29
Merge branch 'master' into master
hawkesn Jun 6, 2024
daf3b89
fix: add testing for divisor on GOMAXPROCS and GOMEMLIMIT
hawkesn Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions traefik/templates/_podtemplate.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,12 +704,14 @@
valueFrom:
resourceFieldRef:
resource: limits.cpu
divisor: '1'
{{- end }}
{{- if ($.Values.resources.limits).memory }}
- name: GOMEMLIMIT
valueFrom:
resourceFieldRef:
resource: limits.memory
divisor: '1'
{{- end }}
{{- with .Values.hub.token }}
- name: HUB_TOKEN
Expand Down
6 changes: 6 additions & 0 deletions traefik/tests/pod-config_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ tests:
- equal:
path: spec.template.spec.containers[0].env[0].valueFrom.resourceFieldRef.resource
value: limits.cpu
- equal:
path: spec.template.spec.containers[0].env[0].valueFrom.resourceFieldRef.divisor
value: "1"
- it: should have set GOMEMLIMIT with cpu limit
set:
resources:
Expand All @@ -29,6 +32,9 @@ tests:
- equal:
path: spec.template.spec.containers[0].env[0].valueFrom.resourceFieldRef.resource
value: limits.memory
- equal:
path: spec.template.spec.containers[0].env[0].valueFrom.resourceFieldRef.divisor
value: "1"
- it: should have not set GOMAXPROCS without cpu limit
asserts:
- notEqual:
Expand Down