feat: allow to set hostAliases for traefik pod #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloiseleur
reviewed
Jun 18, 2024
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
|
@youkoulayley, please merge it if there are no other remarks/improvements that need to be implemented. |
|
@mloiseleur @darkweaver87, no pressure, but when can this PR be expected to be merged(I'm relying on this change due to migration to traefik v3)? |
mloiseleur
reviewed
Jun 19, 2024
mloiseleur
reviewed
Jun 19, 2024
mloiseleur
reviewed
Jun 19, 2024
|
Thanks 👍 . |
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
|
@mloiseleur fixed |
mloiseleur
approved these changes
Jun 20, 2024
mloiseleur
added
status/3-needs-merge
and removed
status/2-needs-review
status/3-needs-merge
labels
|
@mloiseleur, I didn't find any information about releasing new versions with chart improvements, only updates related to the latest version of Traefik (#625 ). How frequently are you delivering new artifacts to the registry with minor improvements/fixes, like this one and #1093, for example? |
|
@x0ddf It depends. There is no hard rule. It's usually after a new release of Traefik Proxy or Traefik Hub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows to set host aliases in the traefik pod.
More
make testand all the tests passed