-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers)!: improve kubernetesGateway and Gateway API support #1107
Conversation
dbb89c6
to
b6a0ff9
Compare
This is great to see better support coming! A couple extra thoughts from a user:
|
@travisghansen I added your suggestions. Considering CRDs I don't have much choice with helm to include it :-/ |
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good 👍
See my comments for last suggestion on how to present it in values.
Awesome! Much appreciated the consideration. A quick overview seems to indicate this has everything I need to cover my current use-case. Once the chart is released however I will give it a thorough try and make sure all is there to handle my currently hacky setup. |
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It seems like the argument here may be in the wrong order, I can't seem to override?
|
What does this PR do?
This PR adds support of new stable kubernetesGateway provider powered by traefik > v3.1.0.
Motivation
Support Traefik v3.1 features.
More
make test
and all the tests passed