Rewrite Companion docs #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
… into companion-docs * 'companion-docs' of https://github.com/transloadit/uppy.io: Fix Github actions preview deploy (#4) re-deploy preview
mifi
reviewed
Aug 10, 2022
mifi
reviewed
Aug 17, 2022
Co-authored-by: Mikael Finstad <finstaden@gmail.com>
Murderlon
commented
Sep 28, 2022
Co-authored-by: Merlijn Vos <merlijn@soverin.net>
also document scaling from transloadit/uppy#4227
|
I have now added scaling docs from transloadit/uppy#4227 and improved a bit. Please let me know if there's anything else I should improve :) |
|
Let's first hammer out the feedback in the other PR, and then copy it here again :) |
Murderlon
commented
Dec 14, 2022
also document some undocumented vars
mifi
reviewed
Dec 16, 2022
mifi
reviewed
Dec 22, 2022
mifi
reviewed
Dec 23, 2022
mifi
reviewed
Dec 23, 2022
mifi
approved these changes
Dec 28, 2022
mifi
added a commit
that referenced
this pull request
Mar 28, 2023
from transloadit/uppy#4382 Also re-add `COMPANION_REDIS_EXPRESS_SESSION_PREFIX` - it was introduced in #5 (d890cb4) but somehow it's now gone. (could other things be gone as well in a botched merge?) also add "This is a standalone-only option" to all standalone-only options. it was only added to one of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://transloadit.github.io/uppy.io/pr-preview/pr-5/docs/companion