Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/compressor: fix upload causing meta name to reset #3890

Merged
merged 1 commit into from
Jul 27, 2022
Merged

@uppy/compressor: fix upload causing meta name to reset #3890

merged 1 commit into from
Jul 27, 2022

Conversation

mellow-fellow
Copy link
Contributor

Fixes #3762

@mellow-fellow mellow-fellow changed the title Fix @uppy/compressor resetting meta name @uppy/compressor: fix upload causing meta name to reset Jul 18, 2022
@arturi arturi self-requested a review July 19, 2022 17:51
Copy link
Member

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would have a test for that.

@aduh95 aduh95 added the safe to test Add this label on trustworthy PRs to spawn the e2e test suite label Jul 22, 2022
@github-actions github-actions bot removed pending end-to-end tests safe to test Add this label on trustworthy PRs to spawn the e2e test suite labels Jul 22, 2022
@aduh95 aduh95 merged commit 2b435bd into transloadit:main Jul 27, 2022
@github-actions github-actions bot mentioned this pull request Jul 27, 2022
github-actions bot added a commit that referenced this pull request Jul 27, 2022
| Package              | Version | Package              | Version |
| -------------------- | ------- | -------------------- | ------- |
| @uppy/companion      |   3.7.1 | @uppy/remote-sources |   0.1.1 |
| @uppy/compressor     |   0.3.1 | @uppy/transloadit    |   2.3.5 |
| @uppy/core           |   2.3.2 | @uppy/robodog        |   2.9.1 |
| @uppy/dashboard      |   2.4.1 | uppy                 |  2.13.1 |
| @uppy/image-editor   |   1.4.1 |                      |         |

- @uppy/compressor: fix upload causing meta name to reset (Justin / #3890)
- @uppy/transloadit: cancel assemblies when all its files have been removed (Antoine du Hamel / #3893)
- e2e: Add retries for flaky e2e test (Merlijn Vos / #3915)
- @uppy/dashboard,@uppy/image-editor,@uppy/remote-sources: Fix `uppy.close()` crashes when remote-sources or image-editor is installed (Merlijn Vos / #3914)
- @uppy/core: Add missing type for retry-all event (Luc Boissaye / #3901)
- @uppy/companion: Companion app type (Mikael Finstad / #3899)
- e2e: upgrade to Cypress 10 (Antoine du Hamel / #3896)
- meta: Fix website build (Murderlon)
- meta: Create new issue templates (Merlijn Vos / #3879)
Murderlon added a commit that referenced this pull request Aug 2, 2022
* 3.x: (32 commits)
  @uppy/screen-capture: fix TODOs (#3930)
  @uppy/status-bar: rename internal modules (#3929)
  @uppy/transloadit: remove static properties in favor of exports (#3927)
  @uppy/informer: simplify `render` method (#3931)
  @uppy/url: remove private methods from public API (#3934)
  @uppy/dashboard: change `copyToClipboard` signature (#3933)
  @uppy/drop-target: remove `isFileTransfer` from the public API (#3932)
  meta: improve beta release script
  Release: uppy@3.0.0-beta.3 (#3918)
  Release: uppy@2.13.1 (#3916)
  Fix exports in propTypes.js to fix website build
  @uppy/compressor: fix upload causing meta name to reset (#3890)
  @uppy/transloadit: cancel assemblies when all its files have been removed (#3893)
  Add retries for flaky e2e test (#3915)
  Fix `uppy.close()` crashes when remote-sources or image-editor is installed (#3914)
  webcam: Add support for mobileNativeCamera option to Webcam and Dashboard (#3844)
  aws-s3-multipart: make `headers` part indexed too in `prepareUploadParts` (#3895)
  Add missing type for retry-all event (#3901)
  Companion app type (#3899)
  e2e: upgrade to Cypress 10 (#3896)
  ...
Murderlon added a commit that referenced this pull request Aug 3, 2022
* 3.x: (30 commits)
  @uppy/screen-capture: fix TODOs (#3930)
  @uppy/status-bar: rename internal modules (#3929)
  @uppy/transloadit: remove static properties in favor of exports (#3927)
  @uppy/informer: simplify `render` method (#3931)
  @uppy/url: remove private methods from public API (#3934)
  @uppy/dashboard: change `copyToClipboard` signature (#3933)
  @uppy/drop-target: remove `isFileTransfer` from the public API (#3932)
  meta: improve beta release script
  Release: uppy@3.0.0-beta.3 (#3918)
  Release: uppy@2.13.1 (#3916)
  Fix exports in propTypes.js to fix website build
  @uppy/compressor: fix upload causing meta name to reset (#3890)
  @uppy/transloadit: cancel assemblies when all its files have been removed (#3893)
  Add retries for flaky e2e test (#3915)
  Fix `uppy.close()` crashes when remote-sources or image-editor is installed (#3914)
  Add missing type for retry-all event (#3901)
  Companion app type (#3899)
  e2e: upgrade to Cypress 10 (#3896)
  Fix website build
  Create new issue templates (#3879)
  ...
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
| Package              | Version | Package              | Version |
| -------------------- | ------- | -------------------- | ------- |
| @uppy/companion      |   3.7.1 | @uppy/remote-sources |   0.1.1 |
| @uppy/compressor     |   0.3.1 | @uppy/transloadit    |   2.3.5 |
| @uppy/core           |   2.3.2 | @uppy/robodog        |   2.9.1 |
| @uppy/dashboard      |   2.4.1 | uppy                 |  2.13.1 |
| @uppy/image-editor   |   1.4.1 |                      |         |

- @uppy/compressor: fix upload causing meta name to reset (Justin / transloadit#3890)
- @uppy/transloadit: cancel assemblies when all its files have been removed (Antoine du Hamel / transloadit#3893)
- e2e: Add retries for flaky e2e test (Merlijn Vos / transloadit#3915)
- @uppy/dashboard,@uppy/image-editor,@uppy/remote-sources: Fix `uppy.close()` crashes when remote-sources or image-editor is installed (Merlijn Vos / transloadit#3914)
- @uppy/core: Add missing type for retry-all event (Luc Boissaye / transloadit#3901)
- @uppy/companion: Companion app type (Mikael Finstad / transloadit#3899)
- e2e: upgrade to Cypress 10 (Antoine du Hamel / transloadit#3896)
- meta: Fix website build (Murderlon)
- meta: Create new issue templates (Merlijn Vos / transloadit#3879)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compressor plugin resets metadata name
2 participants