-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only publish Companion to Dockerhub on release #4037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not a great filter, sometimes we release a new version of Companion without touching its CHANGELOG. E.g., v3.5.1 doesn't have an entry in the changelog:
uppy/packages/@uppy/companion/CHANGELOG.md
Lines 80 to 95 in 9d03b6f
## 3.5.2 | |
Released: 2022-04-27 | |
Included in: Uppy v2.9.5 | |
- @uppy/companion: Bump moment from 2.29.1 to 2.29.2 (dependabot[bot] / #3635) | |
## 3.5.0 | |
Released: 2022-03-24 | |
Included in: Uppy v2.9.0 | |
- @uppy/companion: Companion server upload events (Mikael Finstad / #3544) | |
- @uppy/companion: fix `yarn test` command (Antoine du Hamel / #3590) | |
- @uppy/companion: Allow setting no ACL (Mikael Finstad / #3577) | |
- @uppy/companion: Small companion code and doc changes (Mikael Finstad / #3586) |
Why not use the tag instead? Everytime a new release of Companion is made, we push a tag to the repo, e.g. https://github.com/transloadit/uppy/tree/%40uppy/companion%403.5.1 |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
…into companion-deploy * 'companion-deploy' of https://github.com/transloadit/uppy: Update .github/workflows/companion-deploy.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
| Package | Version | Package | Version | | ------------------------- | ------- | ------------------------- | ------- | | @uppy/angular | 0.4.1 | @uppy/store-default | 3.0.1 | | @uppy/audio | 1.0.1 | @uppy/store-redux | 3.0.1 | | @uppy/aws-s3 | 3.0.1 | @uppy/svelte | 3.0.0 | | @uppy/aws-s3-multipart | 3.0.1 | @uppy/thumbnail-generator | 3.0.1 | | @uppy/companion | 4.0.1 | @uppy/transloadit | 3.0.1 | | @uppy/companion-client | 3.0.1 | @uppy/tus | 3.0.1 | | @uppy/core | 3.0.1 | @uppy/utils | 5.0.1 | | @uppy/dashboard | 3.0.1 | @uppy/webcam | 3.1.0 | | @uppy/react | 3.0.1 | @uppy/xhr-upload | 3.0.1 | | @uppy/remote-sources | 1.0.1 | uppy | 3.0.1 | - @uppy/dashboard,@uppy/webcam: add nativeCameraFacingMode to Webcam and Dashboard (Artur Paikin / #4047) - meta: upgrade to Jest 29 (Antoine du Hamel / #4049) - @uppy/svelte: update peer dependencies (Antoine du Hamel / #4065) - @uppy/react: useUppy: fix unmount on NextJS dev mode (Matt Jesuele / #4062) - @uppy/vue: fix missing component in docs (Antoine du Hamel / #4063) - @uppy/angular: fix compiler warning (Antoine du Hamel / #4064) - meta: improve CI npm install time (Antoine du Hamel / #4058) - meta: example: fix Angular example package name (Antoine du Hamel / #4060) - meta: upgrade to TypeScript 4.8 (Antoine du Hamel / #4048) - @uppy/core,@uppy/dashboard,@uppy/thumbnail-generator: update definition type files for TS 4.8 compatibility (Antoine du Hamel / #4055) - @uppy/transloadit: improve deprecation notice (Antoine du Hamel / #4056) - @uppy/thumbnail-generator: fix `exifr` import (Antoine du Hamel / #4054) - @uppy/utils: fix `relativePath` when drag&dropping a folder (Antoine du Hamel / #4043) - @uppy/companion: Fix Companion license (Merlijn Vos / #4044) - e2e: add tests for AWS (Antoine du Hamel / #3665) - meta: Only publish Companion to Dockerhub on release (Merlijn Vos / #4037) - meta: fix linter warnings (Antoine du Hamel / #4039) - @uppy/utils: Post-release website fixes (Merlijn Vos / #4038) - @uppy/angular: fix peer dependencies (Antoine du Hamel / #4035) - meta: uppy.io homepage: Add Tus (Artur Paikin) - meta: Fix uppy.io homepage example (Artur Paikin)
| Package | Version | Package | Version | | ------------------------- | ------- | ------------------------- | ------- | | @uppy/angular | 0.4.1 | @uppy/store-default | 3.0.1 | | @uppy/audio | 1.0.1 | @uppy/store-redux | 3.0.1 | | @uppy/aws-s3 | 3.0.1 | @uppy/svelte | 3.0.0 | | @uppy/aws-s3-multipart | 3.0.1 | @uppy/thumbnail-generator | 3.0.1 | | @uppy/companion | 4.0.1 | @uppy/transloadit | 3.0.1 | | @uppy/companion-client | 3.0.1 | @uppy/tus | 3.0.1 | | @uppy/core | 3.0.1 | @uppy/utils | 5.0.1 | | @uppy/dashboard | 3.0.1 | @uppy/webcam | 3.1.0 | | @uppy/react | 3.0.1 | @uppy/xhr-upload | 3.0.1 | | @uppy/remote-sources | 1.0.1 | uppy | 3.0.1 | - @uppy/dashboard,@uppy/webcam: add nativeCameraFacingMode to Webcam and Dashboard (Artur Paikin / transloadit#4047) - meta: upgrade to Jest 29 (Antoine du Hamel / transloadit#4049) - @uppy/svelte: update peer dependencies (Antoine du Hamel / transloadit#4065) - @uppy/react: useUppy: fix unmount on NextJS dev mode (Matt Jesuele / transloadit#4062) - @uppy/vue: fix missing component in docs (Antoine du Hamel / transloadit#4063) - @uppy/angular: fix compiler warning (Antoine du Hamel / transloadit#4064) - meta: improve CI npm install time (Antoine du Hamel / transloadit#4058) - meta: example: fix Angular example package name (Antoine du Hamel / transloadit#4060) - meta: upgrade to TypeScript 4.8 (Antoine du Hamel / transloadit#4048) - @uppy/core,@uppy/dashboard,@uppy/thumbnail-generator: update definition type files for TS 4.8 compatibility (Antoine du Hamel / transloadit#4055) - @uppy/transloadit: improve deprecation notice (Antoine du Hamel / transloadit#4056) - @uppy/thumbnail-generator: fix `exifr` import (Antoine du Hamel / transloadit#4054) - @uppy/utils: fix `relativePath` when drag&dropping a folder (Antoine du Hamel / transloadit#4043) - @uppy/companion: Fix Companion license (Merlijn Vos / transloadit#4044) - e2e: add tests for AWS (Antoine du Hamel / transloadit#3665) - meta: Only publish Companion to Dockerhub on release (Merlijn Vos / transloadit#4037) - meta: fix linter warnings (Antoine du Hamel / transloadit#4039) - @uppy/utils: Post-release website fixes (Merlijn Vos / transloadit#4038) - @uppy/angular: fix peer dependencies (Antoine du Hamel / transloadit#4035) - meta: uppy.io homepage: Add Tus (Artur Paikin) - meta: Fix uppy.io homepage example (Artur Paikin)
I didn't agree with the change in #3677, where Companion is deployed on any change in the Companion folder. Users of Docker are forcibly on a nightly version, we could push a broken commit and they get a broken build. It also results in lots of tags and pushes to Dockerhub, people feel like they are always behind.
This PR changes the publish to only happen when a new git tag is pushed for Companion, which is what happens automatically by our GitHub Actions CI when a release happens.