Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically prefix enum names #177

Closed
aprokop opened this issue Dec 17, 2017 · 4 comments
Closed

Automatically prefix enum names #177

aprokop opened this issue Dec 17, 2017 · 4 comments
Assignees

Comments

@aprokop
Copy link
Collaborator

aprokop commented Dec 17, 2017

Otherwise will certainly lead to conflicts. @sethrj sorry, only realized this point now. But we need a quick fix. Could we prefix the enums automatically? Ideally, I'd like to prefix them with something that depends on the module they are in.

@aprokop
Copy link
Collaborator Author

aprokop commented Dec 17, 2017

Luckily, I think I found a quick hack around the issue without touching SWIG. So, we can still keep chugging alone.

@aprokop
Copy link
Collaborator Author

aprokop commented Dec 17, 2017

The workaround is merged as part of #178. But we need an automatic way of doing this (though this can be done after the release).

@aprokop aprokop changed the title Prefix enum names Automatically prefix enum names Dec 17, 2017
@sethrj
Copy link
Collaborator

sethrj commented Mar 8, 2018

Done in #220 : before any of the %includes in each module, add

%rename("Teuchos%s",%$isenumitem) "";
%rename("Teuchos%s",%$isenum) "";

That adds a prefix to all the encountered enums. Adding a similar %rename directive for Tpetra after %import <forteuchos.i> does the same thing.

@aprokop
Copy link
Collaborator Author

aprokop commented Jun 7, 2018

This was merged in 3988d0c, 8a999da and fcad090.

@aprokop aprokop closed this as completed Jun 7, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants