Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Trilinos 14 #292

Merged
merged 11 commits into from
Aug 17, 2023
Merged

Update to Trilinos 14 #292

merged 11 commits into from
Aug 17, 2023

Conversation

sethrj
Copy link
Collaborator

@sethrj sethrj commented Aug 16, 2023

No description provided.

@sethrj
Copy link
Collaborator Author

sethrj commented Aug 17, 2023

No errors, no test failures! Only one warning:

/var/jenkins/workspace/ForTrilinos2/src/fortrilinos_hl/solver_handle.cpp:70:59: warning: 'void Stratimikos::enableMueLu(Stratimikos::LinearSolverBuilder<double>&, const string&) [with LocalOrdinal = int; GlobalOrdinal = long long int; Node = Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial>; std::string = std::__cxx11::basic_string<char>]' is deprecated [-Wdeprecated-declarations]
   70 |     Stratimikos::enableMueLu<LO,GO,NO>(linearSolverBuilder);
      |                                                           ^
In file included from /var/jenkins/workspace/ForTrilinos2/src/fortrilinos_hl/solver_handle.cpp:18:
/opt/trilinos/include/Stratimikos_MueLuHelpers.hpp:87:25: note: declared here
   87 |   MUELU_DEPRECATED void enableMueLu(LinearSolverBuilder<double>& builder, const std::string& stratName = "MueLu")
      |                         ^~~~~~~~~~~
/var/jenkins/workspace/ForTrilinos2/src/fortrilinos_hl/solver_handle.cpp:70:59: warning: 'void Stratimikos::enableMueLu(Stratimikos::LinearSolverBuilder<double>&, const string&) [with LocalOrdinal = int; GlobalOrdinal = long long int; Node = Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial>; std::string = std::__cxx11::basic_string<char>]' is deprecated [-Wdeprecated-declarations]
   70 |     Stratimikos::enableMueLu<LO,GO,NO>(linearSolverBuilder);
      |                                                           ^
In file included from /var/jenkins/workspace/ForTrilinos2/src/fortrilinos_hl/solver_handle.cpp:18:
/opt/trilinos/include/Stratimikos_MueLuHelpers.hpp:87:25: note: declared here
   87 |   MUELU_DEPRECATED void enableMueLu(LinearSolverBuilder<double>& builder, const std::string& stratName = "MueLu")
      |                         ^~~~~~~~~~~

@sethrj sethrj requested a review from aprokop August 17, 2023 12:02
Copy link
Collaborator

@aprokop aprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethrj
Copy link
Collaborator Author

sethrj commented Aug 17, 2023

publishing results using Trilinos, please cite us: https://trilinos.github.io/cite.html

Results are that trilinos takes 10 hours to build when Mueulu is involved 😂

@aprokop
Copy link
Collaborator

aprokop commented Aug 17, 2023

I think it maybe sharing CI host or something.

@sethrj sethrj merged commit 7c21955 into trilinos:master Aug 17, 2023
1 check passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants