[DO NOT MERGE] MueLu: Refactor CoalesceDropFactory_kokkos #12861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgcgcg
added
pkg: MueLu
MueLuReview
cgcgcg
changed the title
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.20-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: cgcgcg |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.20-uvm
Jenkins Parameters
|
cgcgcg
added
the
AT: WIP
cgcgcg
force-pushed
the
coalesceDrop
branch
2 times, most recently
from
bc183ae
to
5f90623
Compare
packages/muelu/src/Graph/MatrixTransformation/MueLu_DroppingCommon.hpp
Outdated
Show resolved
Hide resolved
| auto aiiajj = ATS::magnitude(diag(rlid)) * ATS::magnitude(diag(clid)); // |a_ii|*|a_jj| | ||
| auto aij2 = ATS::magnitude(val) * ATS::magnitude(val); // |a_ij|^2 | ||
|
|
||
| results(offset + k) = (aij2 <= eps * eps * aiiajj) ? DROP : KEEP; |
There was a problem hiding this comment.
It would be useful to note somewhere this is classical (SA) dropping, not classical (RS) dropping
There was a problem hiding this comment.
I'm not sure I understand. What's the difference?
There was a problem hiding this comment.
@GrahamBenHarper means that classical could refer to "Ruge Stueben" or to the standard smoothed aggregation dropping criterion.
36 tasks
cgcgcg
force-pushed
the
coalesceDrop
branch
3 times, most recently
from
2a34193
to
40cfcf7
Compare
cgcgcg
force-pushed
the
coalesceDrop
branch
2 times, most recently
from
98e537d
to
a5dec0f
Compare
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
The Dirichlet threshold detection was not used when the drop tol != 0.
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
cgcgcg
force-pushed
the
coalesceDrop
branch
3 times, most recently
from
9a28985
to
1362ac3
Compare
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/muelu
Motivation
We eventually want to merge
CoalesceDropFactoryandCoalesceDropFactory_kokkos. Some of the dropping schemes (e.g. cut-drop) inCoalesceDropFactoryneed access to the entire row. Moreover, the two factories are so messy because we want to apply a whole variety of different criteria.I refactored the code to enable more composability than before and break up the algorithms into smaller, more readable units. Criteria take the form of functors that are applied to each row. This means that we need at most 3 kernel launches, instead of launching kernels for different criteria one-by-one.
One large change is that I allocate a view for the dropping decisions. On the other hand, we no longer allocate and then shrink a copy of the original matrix.
Questions/todos:
Kokkos_ENABLE_CUDA_CONSTEXPR=ONto allow the use ofstd::get. Is there a way around that?