Framework: Add warnings/errors policy #13427
Open
+195
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add capability for switching 'upcoming' warnings/errors on/off. `Trilinos_WARNINGS` will do the following: `WARN` -> Warnings are added to CXX flags, deprecated packages have all warnings disabled `ERROR` -> Warnings-as-errors are added to CXX flags, deprecated packages have all warnings disabled Anything else -> No warnings/errors adde Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
Just rely on warnings/errors apprach for now. Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
sebrowne
added
the
AT: WIP
cgcgcg
reviewed
Sep 5, 2024
Also add ability to pass extra warnings for experimentation. Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
sebrowne
force-pushed
the
warnings-policy
branch
from
cdc43ce
to
e38553e
Compare
sebrowne
added
AT2-SpecialApprove
Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
sebrowne
added
AT2-SpecialApprove
Moved these three warnings (sign-compare, parentheses, unused-variable) into WarningsErrorsPolicy.cmake. Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
sebrowne
added
AT2-SpecialApprove
I'm about to need the ability to parse an option value, so switching to getopt seems to make sense. Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
sebrowne
added
AT2-SpecialApprove
We're using '-w', but still nice to make it more explicit that we're not adding warnings for those packages. Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
sebrowne
added
AT2-SpecialApprove
sebrowne
force-pushed
the
warnings-policy
branch
from
6fc3f25
to
a75308d
Compare
sebrowne
added
AT2-SpecialApprove
cgcgcg
previously approved these changes
Sep 12, 2024
Can now add a nightly that builds the non-deprecated packages and gives warnings-as-errors. Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
sebrowne
force-pushed
the
warnings-policy
branch
from
37b3457
to
fb904dc
Compare
Makes the reporting nicer. Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
sebrowne
added
the
AT: WIP
This way we can get the cache options from a TriBITS-imported cachefile Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
sebrowne
removed
the
AT: WIP
|
Nightly dashboard with mode set to |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: sebrowne |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
sebrowne
added
the
AT: RETEST
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: sebrowne |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
trilinos-autotester
removed
the
AT: RETEST
sebrowne
added
AT: RETEST
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: sebrowne |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
trilinos-autotester
removed
the
AT: RETEST
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/framework
Motivation
Trilinos would like to minimize compile warnings for its customers. To that end, we would like to add some "standard" warnings that we can use in PR and nightly testing as we move to reduce occurrences from the codebase. We do not want them to show up by default, but do want them to be easily enabled and easily set to errors.
In addition, there is a list of
promoted_warningsthat are errors even if the mode is set toWARN, because that way the PR system can be used to both test adding new warnings, and enforcing that the promoted ones are still valid.Related Issues
https://sems-atlassian-son.sandia.gov/jira/browse/TRILFRAME-669
Testing
I tested with the following commands, and the behavior was as expected:
cmake -DTrilinos_ENABLE_Tempus=ONcmake -DTrilinos_WARNINGS_MODE=WARN -DTrilinos_ENABLE_Tempus=ONcmake -DTrilinos_WARNINGS_MODE=ERROR -DTrilinos_ENABLE_Tempus=ONcmake -DTrilinos_WARNINGS_MODE=WARN -DTrilinos_ENABLE_Teuchos=ON -DTeuchos_CXX_FLAGS="myownflaghere"Depends on #13425 being merged first for cleanliness