Stokhos: refactor create_mirror specialisation for View of MP::Vector
#13433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
etphipp
approved these changes
Sep 9, 2024
|
Hi @etphipp. Thanks for taking a look and giving a thumps up. You forgot to set the labels :) Would you have a moment to set them to launch the test pipeline? Thanks! |
etphipp
added
AT: AUTOMERGE
|
Done, sorry about that. |
trilinos-autotester
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: maartenarnst |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ etphipp ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 13433: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/stokhos
@etphipp
@romintomasetti
@pzehner
This PR refactors the
Stokhosspecialisation ofKokkos::create_mirrorforViewofMP::Vector. This refactoring is motivated by recent changes inKokkosin:create_mirror*toImpl::create_mirror*kokkos/kokkos#7061In that
KokkosPR, additional constraints were imposed in the public interface ofKokkos::create_mirrorandKokkos::create_mirror_view. In particular, the version ofKokkos::create_mirror_viewthat takes aKokkos::Impl::ViewCtorPropnow no longer works with views with a non-voidspecializetrait.This PR thus adds to Stokhos a specialisation of
Kokkos::create_mirrorthat takes aKokkos::Impl::ViewCtorProp. Then, all other overloads are refactor to map to that version. And, in the end, a specialisation ofKokkos::create_mirror_viewis added.We may want to explore with the
Kokkosteam whether the new constraint (std::is_void_v<typename ViewTraits<T, P...>::specialize>) on their public version ofKokkos::create_mirror_viewis really needed. If this constraint could be removed there, the new specialisation ofKokkos::create_mirror_viewin this PR could be removed. But the refactoring ofcreate_mirrorin this PR would still be useful.@etphipp, would you have a moment to take a look? Thanks in advance!