Intrepid2: Initial implementation of team-level getValues #13437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mperego
added
AT: WIP
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| using ScalarType = typename ScalarTraits<typename PointViewType::value_type>::scalar_type; | ||
| using WorkViewType = Kokkos::DynRankView< ScalarType,typename DT::execution_space::scratch_memory_space,Kokkos::MemoryTraits<Kokkos::Unmanaged> >; | ||
| ordinal_type sizePerPoint = 3*this->vinv_.extent(0)*get_dimension_scalar(inputPoints); | ||
| WorkViewType workView(scratchStorage, sizePerPoint*team_member.team_size()); |
Check failure
Code scanning / CodeQL
Multiplication result converted to larger type High
CamelliaDPG
reviewed
Sep 11, 2024
| const PointViewType inputPoints, | ||
| const EOperator operatorType = OPERATOR_VALUE) const { | ||
| INTREPID2_TEST_FOR_EXCEPTION_DEVICE_SAFE( true, std::logic_error, | ||
| ">>> ERROR (Basis::getValuesScratchSpace): this method (FEM) is not supported or should be overridden accordingly by derived classes."); |
There was a problem hiding this comment.
What is the "(FEM)" supposed to convey here? I think the message is clearer without it, but maybe there is something else you wanted to communicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/intrepid2
Motivation
In most cases, we want to evaluate the reference basis functions at a set of reference points (e.g. quadrature points) that is the same for all the cells in a workset. In this case one evaluates the basis functions at these points on the reference cell, using the
getValuesfunction, and then transforms these basis functions to physical cells.In some cases, however, the evaluation points can be different from cell to cell (e.g., in particle in cell methods, we can have different particles in different cells where we want to evaluate the basis functions). For this use-case, we implement a team-level
getValuesfunction, that can be called by the user in a parallel for using aTeamPolicy.Related Issues
Stakeholder Feedback
Testing