Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about retrying on 429 error code #23153

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

hovaesco
Copy link
Member

Description

Add information about retrying on 429 error code accordingly to trinodb/trino-python-client#455 (comment)

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll let @electrum take a look before merging.

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minimal formatting to fix, then good to go.

docs/src/main/sphinx/develop/client-protocol.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/develop/client-protocol.md Outdated Show resolved Hide resolved
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes look good

docs/src/main/sphinx/develop/client-protocol.md Outdated Show resolved Hide resolved
Copy link

cla-bot bot commented Sep 2, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Przemek Denkiewicz.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla-signed label Sep 2, 2024
@cla-bot cla-bot bot added the cla-signed label Sep 2, 2024
@hashhar hashhar merged commit 2236dd3 into trinodb:master Sep 2, 2024
9 checks passed
@github-actions github-actions bot added this to the 456 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants