Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: exposing constructor parameters (e.g. preserveDrawingBuffer) #117

Closed
vphilot opened this issue Jan 12, 2022 · 3 comments
Closed

Question: exposing constructor parameters (e.g. preserveDrawingBuffer) #117

vphilot opened this issue Jan 12, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation
Milestone
0.3.4

Comments

@vphilot
Copy link

vphilot commented Jan 12, 2022

is there a way to provide constructor params when instantiating a renderer with Trois? There are some options that can only be provided when the rendered is instantiated, e.g. preserveDrawingBuffer.

ref: https://threejs.org/docs/#api/en/renderers/WebGLRenderer.preserveDrawingBuffer
@vphilot vphilot changed the title expose constructor parameters (e.g. WebGLRenderer.preserveDrawingBuffer) expose constructor parameters (e.g. preserveDrawingBuffer) Jan 12, 2022
@vphilot vphilot changed the title expose constructor parameters (e.g. preserveDrawingBuffer) Question: exposing constructor parameters (e.g. preserveDrawingBuffer) Jan 12, 2022
@SaFrMo
Copy link
Contributor

SaFrMo commented Jan 21, 2022

There isn't a way right now, but that's a good idea for a feature - the renderer's instantiation is hardcoded here, so that'd be the place to change it. @klevron I can take a look at this in the next week or two, let me know if you'd prefer to take it!

@SaFrMo SaFrMo self-assigned this Jan 21, 2022
@SaFrMo SaFrMo added the enhancement New feature or request label Jan 21, 2022
klevron added a commit that referenced this issue Jan 24, 2022
@klevron
WebGLRenderer constructor params #117
bb63587
@klevron klevron added the documentation Improvements or additions to documentation label Jan 24, 2022
@klevron klevron added this to the 0.3.4 milestone Jan 24, 2022
@klevron
Copy link
Member

klevron commented Jan 24, 2022

Thanks @vphilot for reporting this, it will be possible in next version
@SaFrMo: thanks, already done :)

@SaFrMo SaFrMo removed their assignment Jan 24, 2022
@vphilot
Copy link
Author

vphilot commented Jan 24, 2022

thanks for the amazing work @klevron @SaFrMo

@klevron klevron removed the enhancement New feature or request label Feb 16, 2022
@klevron klevron mentioned this issue Feb 16, 2022
Open
@klevron klevron closed this as completed Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.3.4
Development

No branches or pull requests
3 participants
@klevron @SaFrMo @vphilot