Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix removeListener index #78

Merged
merged 2 commits into from
Jul 2, 2021
Merged

fix removeListener index #78

merged 2 commits into from
Jul 2, 2021

Conversation

yoanngueny
Copy link
Contributor

The first registered event index is 0, so it could not be unregistered.

klevron
klevron requested changes Jul 1, 2021
View reviewed changes
src/core/Renderer.ts Outdated Show resolved Hide resolved
@yoanngueny yoanngueny requested a review from klevron July 2, 2021 07:20
@klevron
Copy link
Member

klevron commented Jul 2, 2021

Thanks 👍

@klevron klevron merged commit c611533 into troisjs:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klevron klevron Awaiting requested review from klevron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoanngueny @klevron