feat(net): use CompletionService to get ip more quickly #55
Conversation
317787106
changed the title
| public static final List<String> ipV4Urls = Arrays.asList( | ||
| "http://checkip.amazonaws.com", "https://ifconfig.me/", "https://4.ipw.cn/"); | ||
| public static final List<String> ipV6Urls = Arrays.asList( | ||
| "https://v6.ident.me", "http://6.ipw.cn/"); |
There was a problem hiding this comment.
Can the service address for obtaining the IP be made a configurable item?
There was a problem hiding this comment.
In fact, there are not many sites that provide this service. There is little necessary to config it manually.
| executor.shutdownNow(); | ||
| } | ||
|
|
||
| return result; |
There was a problem hiding this comment.
If there is an exception in obtaining the IP, should we consider returning a default value?
There was a problem hiding this comment.
The logic is same as before. If it returns null, the result should be checked by upper business.
| long t2 = System.currentTimeMillis(); | ||
| NetUtil.getExternalIpV4(); | ||
| long t3 = System.currentTimeMillis(); | ||
| Assert.assertTrue(t2 - t1 >= t3 - t2); |
There was a problem hiding this comment.
Results are randomized.
There was a problem hiding this comment.
What do you mean "randomized"?
There was a problem hiding this comment.
t2 - t1 >= t3 - t2 doesn't always hold true.
There was a problem hiding this comment.
I have tried this many times, it works well though network is not avaiIable. But i comment this. Add test case of compare ip from different source.
There was a problem hiding this comment.
@chengtx01 @halibobo1205 If the node has multi outer extranet ip, querying from different urls may get different ip. Is there any problem?
| } catch (Exception e) { | ||
| Assert.fail(); | ||
| } | ||
| long t2 = System.currentTimeMillis(); |
There was a problem hiding this comment.
Please remove unused code.
No description provided.