feat(net):send message P2pDisconnectMessage before closing channel #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,6 +29,8 @@ public void start(P2pConfig p2pConfig) { | |||
| ChannelManager.init(); | |||
| DnsManager.init(); | |||
| log.info("P2p service started"); | |||
|
|
|||
| Runtime.getRuntime().addShutdownHook(new Thread(this::close)); | |||
There was a problem hiding this comment.
It should be closed manually.
There was a problem hiding this comment.
libp2p can be an independent process, so it uses shutdown hook. Any thread pool in libp2p will not be closed twice as it will read the condition. We may test it more completely after merging it into java-tron.
xxo1shine
reviewed
Sep 12, 2023
src/main/java/org/tron/p2p/connection/business/handshake/HandshakeService.java
Show resolved
Hide resolved
src/main/java/org/tron/p2p/connection/business/handshake/HandshakeService.java
Outdated
Show resolved
Hide resolved
xxo1shine
reviewed
Sep 12, 2023
src/main/java/org/tron/p2p/connection/business/handshake/HandshakeService.java
Outdated
Show resolved
Hide resolved
jwrct
approved these changes
Sep 12, 2023
xxo1shine
approved these changes
Sep 12, 2023
317787106
added a commit
that referenced
this pull request
Oct 16, 2023
* doc(readme): update libp2p version * feat(net):use CompletionService to get ip more quickly * feat(log):optimize thread's name of log * add new P2pConfig cost * feat(net):use ScheduledThreadPoolExecutor to replace newSingleThreadExecutor * feat(net): optimize p2p handshake logic * optimize test case testGetIP * optimize testcase NetUtilTest * add message length check logic * modify review suggestions * hotfix(net): don't submit new task if server is closing (#56) * hotfix(net): don't submit new task if server is closing * feat(net):send message P2pDisconnectMessage before closing channel (#63) * feat(net):send message P2pDisconnectMessage before disconnect * feat(net):optimize DisconnectReason * feat(net): add shutdown hook * add needToLog in Message * feat(net): don't close P2pService twice * delete duplicate log in HandshakeService * don't send disconnect message if handshake fails * update the version of grpc and protobuf * set isdisconnect to true when closeFuture happens (#68) * set isdisconnect=true when closeFuture happens * add log of getip's time cost * update version and modify test case (#69) --------- Co-authored-by: halibobo1205 <halibobo1205@gmail.com> Co-authored-by: halibobo1205 <82020050+halibobo1205@users.noreply.github.com> Co-authored-by: wubin01 <wb_bupt@163.com> Co-authored-by: chengtx01 <allen_cheng1@163.com> Co-authored-by: allen <56535423+jwrct@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.