add message length check logic #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwrct
reviewed
Sep 7, 2023
|
|
||
| int length = Snappy.uncompressedLength(data); | ||
| if (length >= Parameter.MAX_MESSAGE_LENGTH) { | ||
| throw new IOException("message is too big, len=" + length); |
There was a problem hiding this comment.
Suggest optimizing the exception information, it should also be that the message after decompression is too large.
There was a problem hiding this comment.
These two IOException can be merged into one.
There was a problem hiding this comment.
you can use P2pException MESSAGE_WITH_WRONG_LENGTH
There was a problem hiding this comment.
Modified, the two checks cannot be combined, the length must be checked before decompression.
317787106
reviewed
Sep 12, 2023
| } | ||
| return d2; | ||
| } |
There was a problem hiding this comment.
int length = Snappy.uncompressedLength(data);
byte[] d2 = null;
if(length < Parameter.MAX_MESSAGE_LENGTH){
d2 = Snappy.uncompress(data);
}
if(length >= MAX_MESSAGE_LENGTH || d2.length >= Parameter.MAX_MESSAGE_LENGTH){
throws P2pException;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.