feature: add getheader method. #502
Merged
+82
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halibobo1205
force-pushed
the
feat/add_header_query
branch
2 times, most recently
from
1acecb2
to
4777991
Compare
halibobo1205
force-pushed
the
feat/add_header_query
branch
from
4777991
to
37bbf7e
Compare
| boolean detail = false; | ||
| if (parameters == null || parameters.length == 0) { | ||
| // query current header | ||
| System.out.println("Get current header !!!"); |
There was a problem hiding this comment.
if no parameters, it should remind how to use the command and then return.
such as "GetBlockByIdOrNum needs 2 parameters like following: "
...
| @@ -1083,4 +1083,23 @@ public Optional<MarketOrder> getMarketOrderById(byte[] order) { | |||
| return Optional.ofNullable(orderPair); | |||
| } | |||
|
|
|||
| public Optional<BlockExtention> getBlock(String idOrNum, boolean detail) { | |||
There was a problem hiding this comment.
use BlockExtention instead of BlockExtention
halibobo1205
force-pushed
the
feat/add_header_query
branch
from
37bbf7e
to
5fc1237
Compare
waynercheung
approved these changes
Jul 28, 2022
| idOrNum = parameters[0]; | ||
| } | ||
| } else { | ||
| idOrNum = parameters[0]; |
There was a problem hiding this comment.
we should check if the input blocknum is negative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.