ci: change action used for storybook deploy #2843
Conversation
jpandersen87
changed the title
| @@ -42,9 +47,9 @@ jobs: | |||
| run: yarn build-storybook | |||
There was a problem hiding this comment.
I wonder if we need this step still? (And the yarn install above it too?)
Looks like this github action does both of those for us
There was a problem hiding this comment.
Agree on this feedback, not sure we need the steps Brandon noted. Can we trigger this build before merging it? I am not sure and I know that's not always possible with GHA.
There was a problem hiding this comment.
Oh yeah, actually, i just duplicated the branch to our repo and it's now available in the Actions tab
Should I run it?
There was a problem hiding this comment.
yarn install/build-storybook steps have been removed
There was a problem hiding this comment.
@jpandersen87 it was easier for us to test and iterate on a Truss-owned branch. If you make your PR diff match https://github.com/trussworks/react-uswds/pull/2844/files, I'm happy to approve so you get the credit!
Thanks for taking the time! PS: Our latest storybook deploy is live thanks to this change: https://trussworks.github.io/react-uswds/
There was a problem hiding this comment.
@jpandersen87 you're so fast. Literally did this as/before I recommended it
There was a problem hiding this comment.
haha, I was watching the deploy and saw the node16 warnings and made the action version update changes literally the same time as you did
werdnanoslen
changed the title
|
@all-contributors please add @jpandersen87 for infra |
|
I've put up a pull request to add @jpandersen87! 🎉 |
Summary
Changes the github action used for storybook deployment to one suggested by Storybook in their documentation on deployment to Github Pages (see: https://storybook.js.org/docs/sharing/publish-storybook#github-pages) in order to hopefully resolve errors in the current storybook deployment.