systemd: use Type=simple and no fork to avoid PIDFile race #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a long-running process that once started by systemd should stay running forever. In the event of a fatal error and unclean exit, we want systemd to restart the program. We use on-abnormal because there are valid nonzero exit codes (EX_USAGE, EX_OSERR, EX_CONFIG) which the program can properly return indicating a configuration or command line error, or inability to allocate memory early on. In these events, restarting would be inappropriate, but on-failure would try anyhow.
|
Would it be possible/desirable to use Type=notify instead? |
|
Type=notify would be possible if the app is enhanced to call sd_notify(3) following startup. But this seems to only matter if we have services (e.g. the MTA) configured to depend on opendmarc such that it's not started until after opendmarc (and other similar milters) have started, which also is not the case. Right now there is no ordering between opendmarc, openarc, opendkim, and sendmail, at least on a CentOS 8 and a Fedora 35 system. Nor does postfix have a startup dependency ordering on these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.