Skip to content
This repository has been archived by the owner on Apr 21, 2020. It is now read-only.

Tokens show balance #256

Merged
merged 3 commits into from
Apr 1, 2018
Merged

Tokens show balance #256

merged 3 commits into from
Apr 1, 2018

Conversation

kolya182
Copy link
Contributor

@kolya182 kolya182 commented Apr 1, 2018

Fixes Fixes #217

@vikmeup
Copy link
Contributor

vikmeup commented Apr 1, 2018

@kolya182 @mykola are you doing batching for balances?

@vikmeup
Copy link
Contributor

vikmeup commented Apr 1, 2018

@vikmeup what is balance check fails, would it return the tokens view?

@kolya182 kolya182 requested a review from vikmeup April 1, 2018 20:35
@kolya182
Copy link
Contributor Author

kolya182 commented Apr 1, 2018

@vikmeup For now just map balances, i will think how to fit BatchRequest

@BlackDuckCoPilot
Copy link

Black Duck Security Report

Branch master has no Black Duck results, and could not be compared to #256. Analyze branch master to get a change comparison.

Removed Components

Medium Risk: 1
Clean: 1048

Click here to see full report

Copy link
Contributor

@vikmeup vikmeup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create separate task for batching

@kolya182 kolya182 merged commit f7e7cca into master Apr 1, 2018
@kolya182 kolya182 deleted the toknes-show-balance branch April 1, 2018 23:36
@kolya182 kolya182 changed the title Toknes show balance Tokens show balance Apr 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants