Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutation rate in time units example #344

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

lkirk
Copy link
Contributor

@lkirk lkirk commented Jun 10, 2024

The branch diversity stat was being scaled by 1e-8 instead of 2e-8, leading to the underestimation of branch diversity when scaled by generation time.

I've corrected the code example and the text.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.65%. Comparing base (4cb44e2) to head (9d53350).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files           8        8           
  Lines         621      621           
  Branches      131      131           
=======================================
  Hits          594      594           
  Misses         18       18           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petrelharp
Copy link
Contributor

Good catch - and thanks for the PR! Here's where mutation rate is indeed set to 2e-8.
(The test failure is a transient CI failure; I'll merge this.)

@petrelharp petrelharp merged commit 847965c into tskit-dev:main Jun 10, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants