add go.mod, allow overriding rand.Reader and time.Now #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add go.mod
A basic go.mod file with go 1.14 requirement (N-3 at the moment). It could be older or newer if you wish.
allow overriding rand.Reader and time.Now and make Registration.Authenticate and NewChallenge backward compatible
We run u2f in a special environment with a custom time provider, so it's a must for us. rand.Reader override makes tests a bit cleaner IMO. First commit adds Config in a clean but incompatible way. Second commit makes the changes backward compatible. I based the changes on #13 (comment)