New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more robust readXcodeMajorVersion #20

Merged

ttypic merged 1 commit into ttypic:main from kalinjul:fix-get-xcode-version

Nov 24, 2023

Contributor

kalinjul commented Nov 17, 2023

Hi, I've got another PR.
I tested version 0.5.0 and got the error "Can't find Xcode".
Output of xcodebuild -version is:

xcodebuild -version
Xcode 15.0
Build version 15A240d

So the regex didn't match. I guess it should be more robust to match more version strings (there could be special strings for RC's as well).


          fix: more robust readXcodeMajorVersion

db40896

ttypic approved these changes

View reviewed changes

Owner

ttypic left a comment

Great! Thank you!

ttypic merged commit ba6b0cc into ttypic:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet