Use clang modules in cinterop instead of headers #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IlyaGulya awesome! does this fix #25? |
Yes, it should be fixed. 🙂 |
… arguments for swift build. Some logging.
IlyaGulya
force-pushed
the
feature/cinterop-modules-instead-of-headers
branch
from
058a392
to
e58f2be
Compare
…d of configuration phase
IlyaGulya
force-pushed
the
feature/cinterop-modules-instead-of-headers
branch
from
e58f2be
to
dad59aa
Compare
markst
added a commit
to markst/radioplayer-kt
that referenced
this pull request
Jul 17, 2024
|
@IlyaGulya are we able to tag this release? |
Sure, I'll try to do it later this week. |
|
@markst this is available in latest release: https://github.com/ttypic/swift-klib-plugin/releases/tag/v0.6.2 |
|
Thanks @IlyaGulya ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #31 and should be reviewed and merged after #31.
This change makes
cinteropsupport usage of clang modules in Objective-C headers.This is required to be able to use any modern apple framework (including
UIKit,AVFoundation, etc).Basically, any Objective-C header containing
@importdirective requires modules to be enabled.This change seems to be backwards compatible since we are generating cinterops for our own builds which are guaranteed to be clang modules.
Also, I've added
iosX64andiosSimulatorArm64to list of targets which are required sdk path to be provided toswift build.Finally, I've fixed all configuration cache issues.
Also, this fixes issue #25