Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

issue with stream parsing #10

Open
tuananh opened this issue Jun 12, 2020 · 1 comment · May be fixed by #11
Open

issue with stream parsing #10

tuananh opened this issue Jun 12, 2020 · 1 comment · May be fixed by #11
Labels
bug Something isn't working critical

Comments

@tuananh
Copy link
Owner

tuananh commented Jun 12, 2020

right now, it will throw error when at the end of chunk (highWaterMark).

this is a major issue because parsing the whole string is kind of defeating the purpose of this lib.

this issue wasn't tested is because the default highWaterMark is pretty high (64kb) IIRC vs size of strings in test cases

Error [ERR_UNHANDLED_ERROR]: Unhandled error. ({
  code: 'ERR_BAD_END_ELEMENT',
  offset: '\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'
})

potential solution:

do sth like this https://github.com/silviucpp/erlxml/blob/master/c_src/xmlstreamparser.cc

once we find a complete stanza, we pass to SaxParser to parse

@tuananh tuananh added the bug Something isn't working label Jun 12, 2020
tuananh added a commit that referenced this issue Jun 13, 2020
@tuananh tuananh linked a pull request Jun 26, 2020 that will close this issue
@tuananh
Copy link
Owner Author

tuananh commented Nov 9, 2021

@Lucabenj it was just one of my hobby weekend project. i no longer working on this :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working critical
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant