Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unicode escapes #16

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Handle unicode escapes #16

merged 4 commits into from
Sep 19, 2023

Conversation

yryuvraj
Copy link
Contributor

@yryuvraj yryuvraj commented Sep 19, 2023 •
edited by tusharsadhwani
Loading

  • Instead of relying on ast.literal_eval, we now manually handle unicode escapes.
  • Since ast.literal_eval was removed, we have to manually unquote the string as well before making it a Constant node.

Resolves #8

tusharsadhwani
tusharsadhwani approved these changes Sep 19, 2023
View reviewed changes
Copy link
Owner

@tusharsadhwani tusharsadhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tusharsadhwani tusharsadhwani merged commit 32c86f2 into tusharsadhwani:main Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharsadhwani tusharsadhwani tusharsadhwani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support unicode escapes
2 participants
@yryuvraj @tusharsadhwani