Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully respect grid settings #112

Closed
wants to merge 1 commit into from
Closed

Conversation

peburrows
Copy link

Make sure all the values required to setup the grid are dynamic and pulled from user-defined variables instead of being hard-coded.

@fat
Copy link
Member

fat commented Aug 27, 2011

is your whitespace off here? are you using tabs instead of spaces?

@peburrows
Copy link
Author

No, I'm using spaces instead of tabs.

The whitespace changes (automatically done by the Save command in TextMate setup because of a whitespace bundle I have installed) are either a) removing trailing whitespace, or b) converting tabs to spaces.

@mdo
Copy link
Member

mdo commented Aug 27, 2011

Ah, interesting about the tabs/spaces. I'll run through our files once more and check for any spacing issues—we should be using soft-tabs with 2-spaces. Thinking about this now, we should add it to the docs for contributors.

@peburrows, can you run the make to get the compiled CSS as part of this pull?

@mdo
Copy link
Member

mdo commented Aug 27, 2011

Actually, making this part of the next release. Got it accounted for in the 1.2-wip branch we have right now.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants