Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #17964 #17997

Merged
merged 3 commits into from
Oct 30, 2016
Merged

Fix #17964 #17997

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d1cbc1
Fix #17964
iliasch Oct 20, 2015
a9ebfd3
Add missing semi-colon
iliasch Oct 20, 2015
1f63f18
Remove extra semi-colon
iliasch Oct 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/src/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ const Util = (($) => {
},

reflow(element) {
new Function('bs', 'return bs')(element.offsetHeight)
return element.offsetHeight
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semicolon is forbidden.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is necessary to adjust the hound...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javascript write without _ (undescore) https://houndci.com/configuration#javascript.

I think java_script is ignore in .hound.yml

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed in 18ad53f

},

triggerTransitionEnd(element) {
Expand Down