Fix vertical alignment issue on floated label in list group item #18579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roup item to fix vertical alignment issue
| .list-group-item .label.pull-#{$breakpoint}-left, | ||
| .list-group-item .label.pull-#{$breakpoint}-right { | ||
| position: relative; | ||
| top: #{(($line-height / .75) - 1 - .5) / 2}em; |
There was a problem hiding this comment.
Line should be indented 6 spaces, but was indented 8 spaces
gaga1227
changed the title
|
I'm unsure exactly what the fix should be here, but I don't think this is the right one just yet. Going to close this out and leave the issue open until I can find a better solution that doesn't require extra positioning on top of a float utility as used today. Thanks though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18574
Adding a position adjustment to compensate vertical positioning difference due to different font-size and line-height values.