Add responsive spacing utility classes #20570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| @include spacing-utility(''); | ||
| @include spacing-utility('-xs'); |
|
This was brought up previously and turned-down (for good reason): #18490 In any case, this should follow the convention used for defining the other responsive utilities: @each $breakpoint in map-keys($grid-breakpoints) {
@include media-breakpoint-up($breakpoint) {
// ...
}
}Example: |
cvrebert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had this come up with my team. Designer wanted to have some spacing for mobile be different from other devices (desktop/tablet), so I added this onto the spacing utility and seems to work well!
More than happy to make any changes that people think are necessary. (For instance, wasn't sure if since I made this into a mixin if I should move it to the mixin folder now)