Container padding uses per-breakpoint gutter sizes, fixes #19304. #20973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelbandito
force-pushed
the
container-gutter-breakpoints
branch
from
b8551cc
to
e1fefe6
Compare
|
@mdo I closed this PR because the Savage check seemed to be stalled. I didn't see that you'd already added it to the milestone. I opened a different PR instead (#20984) to try to trigger a new check, hoping the stalled test would resolve itself. Sorry for messing up the process. Would you like me to close the other PR and reopen this one? For future reference: is it normal for Savage checks to stay in a pending state for multiple days? |
|
Savage is always a little weird. Just ignore it unless it fails. I think reopen this one. |
Yeah, unsure what's up with that. Maybe @cvrebert can peep it? |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping this is what was intended by issue #19304. I'm re-using the per-breakpoint setting for gutters as the padding base for containers.