Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect select height calculation #21171

Merged
merged 1 commit into from
Nov 28, 2016
Merged

Conversation

schliflo
Copy link
Contributor

@schliflo schliflo commented Nov 21, 2016

This fixes a bug where the height of the select element was calculated incorrectly when using a $line-height-base with a value other that 1.5 (which is the current default).

Fixes #20977.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Nov 28, 2016
@mdo mdo merged commit 959c4e5 into twbs:v4-dev Nov 28, 2016
mdo added a commit that referenced this pull request Dec 23, 2016
Turns out we did have the correct height calculation with our custom selects. The problem was we lacked a shared line-height with our buttons and inputs.

This restores the previous `calc` math and adds a line-height that reuses the input line-height.
@mdo
Copy link
Member

mdo commented Dec 23, 2016

As a heads up, I'm undoing this change in 8e455ff. I think we had it right before, but missed out on the line-height that was shared. Should've fixed that instead of just changing calc.

mdo added a commit that referenced this pull request Dec 24, 2016
Turns out we did have the correct height calculation with our custom selects. The problem was we lacked a shared line-height with our buttons and inputs.

This restores the previous `calc` math and adds a line-height that reuses the input line-height.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants