Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inline forms (updated docs and new flexbox styles) #21212

Merged
merged 21 commits into from
Nov 27, 2016
Merged

Conversation

mdo
Copy link
Member

@mdo mdo commented Nov 26, 2016

Supersedes #19129, fixes #18406.

This branch takes the work started by @wojtask9 and builds on it heavily to address some inline form styling issues, for the default and flexbox modes. Specifically:

  • Provides flexbox support for inline forms, including inputs, input groups, selects, checks, custom selects, custom checks, and buttons.
  • Adjusts the default mode styling for alignment of (custom) checks.
  • Updates the docs to remove the hidden/visible label demos and replace them with more complete examples featuring all control types and margin utils for spacing.
  • Updates the usage guidelines to mention flexbox and crosslink some stuff.

Here's how the docs look now.

screen shot 2016-11-26 at 1 28 53 pm

screen shot 2016-11-26 at 1 29 01 pm

screen shot 2016-11-26 at 1 29 08 pm

@mdo mdo added this to the v4.0.0-alpha.6 milestone Nov 26, 2016
label {
display: flex;
flex-direction: column;
justify-content: center;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered display, flex-direction, margin-bottom, justify-content

@mdo mdo merged commit e17e75b into v4-dev Nov 27, 2016
@mdo mdo deleted the inline-forms-update branch November 27, 2016 00:55
@mdo mdo mentioned this pull request Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants