Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes: #21412: Fix unit test for carousel #21413

Merged
merged 1 commit into from
Dec 23, 2016
Merged

Closes: #21412: Fix unit test for carousel #21413

merged 1 commit into from
Dec 23, 2016

Conversation

Johann-S
Copy link
Member

@Johann-S Johann-S commented Dec 23, 2016 •
edited by bardiharborow
Loading

Should fix build failed due to dab6a41. Closes #21412.

@bardiharborow
Copy link
Member

My apologies about this. It seems that #19058 moved the event.preventDefault() that #20907 removed, and GitHub failed to raise a conflict, resulting in the directive being added twice.

@bardiharborow bardiharborow added this to the v4.0.0-alpha.6 milestone Dec 23, 2016
@bardiharborow bardiharborow merged commit b0508a9 into twbs:v4-dev Dec 23, 2016
@mdo mdo mentioned this pull request Dec 23, 2016
Closed
@Johann-S Johann-S deleted the fixCarouselKeyDown branch December 23, 2016 11:58
@Johann-S
Copy link
Member Author

it's happened sometimes not a big deal @bardiharborow 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
v4.0.0-alpha.6
Development

Successfully merging this pull request may close these issues.
2 participants
@Johann-S @bardiharborow