v4: Mixing auto margins with flexbox #21426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Correct me if i'm wrong, but |
|
Hmm, doesn't seem to be the case with flexbox. Here's how the
|
|
Huh, never thought about it being in a flex container. Most of the sources I saw online were before flexbox, so that's where I must have got the idea that For completeness, I think you should also add the |
houndci-bot
reviewed
Dec 25, 2016
| // Some special margin utils | ||
| @include media-breakpoint-up($breakpoint) { | ||
| $infix: breakpoint-infix($breakpoint, $grid-breakpoints); | ||
|
|
Starsam80
approved these changes
Dec 25, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out auto margins and flexbox make an amazing team. I discovered this while working on #21425 and really wanted to put something together for it. Using
margin-{direction}: autoon a flex item will automatically place it on the opposite end of the flex items (when mixed withjustify-contentoralign-items, at least). This makes for some awesome layout opportunities that are perfect for grids, modal footers, cards, and more.