Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing unnecessary id/aria-labelledby for dropdown menus #36487

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

patrickhlauke
Copy link
Member

see #35755

Note that even the APG guide for disclosure widgets doesn't use this optional "nice-to-have" extra bit https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/ (though they do use aria-controls, which in most current browser/AT combos is borked though)

see #35755

Note that even the APG guide for disclosure widgets doesn't use this optional "nice-to-have" extra bit https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/ (though they do use `aria-controls`, which in most current browser/AT combos is borked though)
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Haven't found any other things to delete.
I suppose it should be backported to v4-dev after the merge.

@patrickhlauke patrickhlauke merged commit 8965b11 into main Jun 3, 2022
@patrickhlauke patrickhlauke deleted the patrickhlauke-remove-optional-aria-labelledby branch June 3, 2022 10:18
mwszekely pushed a commit to mwszekely/bootstrap that referenced this pull request Jun 8, 2022
…wbs#36487)

see twbs#35755

Note that even the APG guide for disclosure widgets doesn't use this optional "nice-to-have" extra bit https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/ (though they do use `aria-controls`, which in most current browser/AT combos is borked though)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants