Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .d-none instead of inline styling #38542

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Use .d-none instead of inline styling #38542

merged 1 commit into from
Jun 1, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented May 2, 2023

Description

This PR proposes to use .d-none instead of inline styling (style="display: none") whenever possible. Especially in our examples for the list of SVGs defined at the beginning of the file.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live preview

@julien-deramond julien-deramond marked this pull request as ready for review May 2, 2023 21:00
@julien-deramond julien-deramond requested a review from mdo May 14, 2023 15:53
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@mdo mdo merged commit b5772d4 into main Jun 1, 2023
@mdo mdo deleted the main-jd-use-d-none branch June 1, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants