-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: fix 'Events' JS example #38554
Merged
Merged
Doc: fix 'Events' JS example #38554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced May 24, 2024
This was referenced May 24, 2024
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This PR changes the "Events' JS example showing how to use
show.bs.modal
andevent.preventDefault()
.My proposal here is to simply remove the
if (!data)
condition which can be difficult to understand for readers becausedata
doesn't exist. Certainly, the example is not very useful except for being informative. Maybe you have other ideas here :)Type of changes
Checklist
npm run lint
)Live previews
Related issues
Closes #38552