-
Notifications
You must be signed in to change notification settings - Fork 3
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider consistent naming between the ruleset and the rules #1
Comments
True, the toolchain called As for the name of the ruleset, if it only exposes a This ruleset already supports discovering and exposing externally installed tools as a toolchain. It seems natural to extend the ruleset to expose other, maybe user-defined, collections of tools. My reading of Also looping in @laszlocsomor who suggested |
Thanks for looping me in. I have no preference on naming here. I suggested "rules_sh" because "sh" is the prefix for Bazel's shell rules, and I valued the consistency in naming. But that's merely my opinion. However, let's be clear that Bazel's terminology is incorrect:
The reason for the misnomer is probably lost in time. The shell rules have always been "sh_" rules, for as long as I can remember. |
Hm, simply following the precedent set by the For consistency, I further propose to have the entrypoint for POSIX utilities be Does that sound good to everyone? |
SGTM |
Yes, sounds good. I'll make those changes. |
The proposed changes have been implemented in #2. So, there doesn't seem to be anything actionable left in this issue. |
Currently, the ruleset is called rules_sh. But what is the scope of this ruleset exactly? What is currently implemented is a toolchain that exposes a set of standard "Unix" utilities, as defined by IEEE Std 1003.1-2008. But this standard is also commonly known as a particular version of POSIX (see here). So we could as well call "posix" everything we currently name "unix". This would be less confusing for Windows users, who likewise may want to use this toolchain (especially inside a MinGW shell, or inside WSL).
If we're calling the currently implemented toolchain "posix", then we might as well call the ruleset rules_posix. This would likewise be less confusing, and in keeping with the convention documented here that a rule set foo normally exposes a rules pertaining to foo as its main entry point. "sh" is a particular type of shell, ususually the Bourne shell, so is oddly specific if the intended scope of this ruleset is bigger than just exposing POSIX utilities (maybe equivalents for Microsoft shells could be considered in the future).
The text was updated successfully, but these errors were encountered: